search

pandorabox-io / pandorabox_custom

pandorabox server customization mod
https://pandorabox.io
MIT License
4 stars 7 forks source link

Add craft recipes for `digilines:rtc` and `digilines:lightsensor` #41

Closed OgelGames closed 3 years ago

OgelGames commented 3 years ago

Both of these nodes should have craft recipes, as they are not "game-breaking" nodes; this PR adds recipes for them:

rtc lightsensor

@S-S-X @SwissalpS @FeXoR-o-Illuria any suggestions/objections?

@BuckarooBanzay the admin vendor for digilines:rtc can be removed after this ;)

S-S-X commented 3 years ago

Could these be added directly to mod? Is there some actual reason why these do not have recipes there?

Did quick search on issues and did not find anything so maybe move this stuff to upstream?

OgelGames commented 3 years ago

Well the main reasons were because the change will be quicker here, and because I wanted to use basic_materials items in the recipe, but you're right, it would make more sense for the recipes to be added upstream.

OgelGames commented 3 years ago

https://github.com/minetest-mods/digilines/pull/71

Probably could still use this PR in the meantime though, or if we want better recipes...

S-S-X commented 3 years ago

minetest-mods/digilines#71

Probably could still use this PR in the meantime though, or if we want better recipes...

Agreed these are better recipes than what dependencies for digilines can ever allow.

Also side note looked a bit around previous digiline recipes and seems like those few that are available are also using ingredients from mods that are not listed as dependencies.... well, mesecons and most probably wont use digilines without mesecons but anyway.