pandorabox-io / pandorabox_custom

pandorabox server customization mod
https://pandorabox.io
MIT License
4 stars 7 forks source link

add hud-warning if protection_bypass is enabled #50

Open BuckarooBanzay opened 2 years ago

BuckarooBanzay commented 2 years ago

only for non-admins (players without "privs" priv)

screenshot_20220112_092353

OgelGames commented 2 years ago

Good idea 👍 (text is slightly too far to the right though)

S-S-X commented 2 years ago

Seems somewhat good direct action to workaround existing problem but also something that should not be needed in first place. Makes me wonder if there's some problem with said privilege use?

BuckarooBanzay commented 2 years ago

Good idea +1 (text is slightly too far to the right though)

Uh, you're right, but it should be perfectly centered with { x=0.5, y=0.5 } :confused:

Seems somewhat good direct action to workaround existing problem but also something that should not be needed in first place. Makes me wonder if there's some problem with said privilege use?

The rationale is: protection_bypass can be granted for a limited time to trusted users (maybe with a proper "privilege elevation" command in lua-code instead of command blocks, just an idea) To ensure that the priv gets revoked as soon as possible a "nagging" text should inform the player about the special condition.

Do you have an alternative suggestion for cleanups that require higher privileges?

S-S-X commented 2 years ago

Do you have an alternative suggestion for cleanups that require higher privileges?

Not for actual privileges / ways to carry out required actions but I think it would be good to have alternative way to drop privileges.

maybe with a proper "privilege elevation" command in lua-code instead of command blocks, just an idea

I mean this but not for gaining privileges, just for dropping privileges. Command block is good as it requires player to actually move to control room to gain extra privileges but I think it would be a lot better to allow dropping privileges instantly without going to some specific location. (having teleport ability or /control command does not really affect this, it is good to require extra "thing" as that makes people think twice if high privileges are really needed)

Chat command to drop privileges but not to gain privileges? And also add that chat command to hud message.

To ensure that the priv gets revoked as soon as possible a "nagging" text should inform the player about the special condition.

Yeah, I think it is needed here... It probably is just that I do myself strongly believe in proper training / sharing knowledge so that people who have access to stuff requiring high privileges also completely understand why they have access, how to use privileges, how to not use privileges and why it is important to drop privileges as soon as possible. While I would like that option very much I guess training like that is not really possible here...

OgelGames commented 2 years ago

it should be perfectly centered with { x=0.5, y=0.5 } 😕

Maybe this value needs changing? https://github.com/pandorabox-io/pandorabox_custom/blob/aa4963ff7523c127a5b3250422bec774f84971a0/protection_bypass_warn.lua#L69

SwissalpS commented 2 years ago

I like this because a player might log off before going to /control to revoke his override priv and would instantly be aware that he still has it when he logs back on.

BuckarooBanzay commented 2 years ago

Command block is good as it requires player to actually move to control room to gain extra privileges but I think it would be a lot better to allow dropping privileges instantly without going to some specific location.

how about an "expiration" timer for the priv plus chat-commands: you can grant it to yourself with /protection_bypass_sudo and revoke it either with protection_bypass_drop or it will automatically be revoked on logout/after 10 minutes

OgelGames commented 2 years ago

how about an "expiration" timer for the priv plus chat-commands

👍 Could probably use a single command to toggle it though (/protection_bypass)