search

pandorabox-io / pandorabox_custom

pandorabox server customization mod
https://pandorabox.io
MIT License
4 stars 8 forks source link

ehlphabet stickers #53

Open SwissalpS opened 2 years ago

SwissalpS commented 2 years ago

adds missing recipes for mandarin stickers

I'm not sure we really need this though. Arguably we could also move the recipe override into this file too (from crafts.lua)

OgelGames commented 2 years ago

Hmm... This doesn't work for me... 🤔

SwissalpS commented 2 years ago

Hmm... This doesn't work for me... thinking

As in you don't like the concept or as in it doesn't technically work and doesn't add the recipes for you?

OgelGames commented 2 years ago

It doesn't add the recipes.

BuckarooBanzay commented 2 years ago

this is essentially the same as this one: https://github.com/minetest-mirrors/ehlphabet/pull/1 right? We could merge this and remove it neverafterwards when the upstream repo has accepted the changes

SwissalpS commented 2 years ago

this is essentially the same as this one: minetest-mirrors/ehlphabet#1 right? We could merge this and remove it ~never~afterwards when the upstream repo has accepted the changes

yes, that's what it's about. It's nothing urgent, we could also wait a couple months until upstream ads them too ;)

SwissalpS commented 2 years ago

It doesn't add the recipes.

weird, admittedly I didn't test in this exact configuration. Will give it another try soon. (not high on my priorities list)

SwissalpS commented 2 years ago

OK, I see what you mean now. I've been testing with inspection tool which does show the recipes but unified_inventory does not pick them up for some reason. Possibly registering a crafting method for the ingredients is required.

OgelGames commented 2 years ago

Ah, it's probably because they have the not_in_creative_inventory group 🤦

Possibly registering a crafting method for the ingredients is required.

How are the "stickers" created currently? I didn't see a way to make them with the letter machine... 🤔

SwissalpS commented 2 years ago

insert paper for stickers, ehlphabet blocks for blocks.

SwissalpS commented 2 years ago

Ah, it's probably because they have the not_in_creative_inventory group

thanks. Makes sense for the normal characters.

SwissalpS commented 2 years ago

fixed it in my PR to mirror repo https://github.com/minetest-mirrors/ehlphabet/pull/1/commits/46abfc243d2a4d8951d2400b4640503caf94da3c

doing an override here seems overkill :/

SwissalpS commented 2 years ago

FYI: on this branch https://github.com/SwissalpS/ehlphabet/tree/unified_inventorCompat I've added unified_inventory support which adds all the items to crafting guide with 'printing' method.