pandorabox-io / pandorabox_custom

pandorabox server customization mod
https://pandorabox.io
MIT License
4 stars 8 forks source link

stealth node blast resistant concrete is no longer blast-resistant #58

Open dennisjenkins75 opened 2 years ago

dennisjenkins75 commented 2 years ago

TYVM for merging https://github.com/pandorabox-io/pandorabox_custom/pull/57.

Sadly, in the war zone, the material (when solid) is not blast-resistant. BRC itself is immune to cannon fire (tested, w/ all 3 cannon sizes), but the new stealth-node variant is not.

I suspect that we should send a PR to the stealthnode mod so that any stealth-node inherits the on_blast of the original node that it was modeled after. Well, that could be bad though, as some nodes have custom on_blast that drops items from inventory.

Maybe we should make a minor change to pandorabox_custom so that it patches the mesecons_stealthnode:technic_blast_resistant_concrete to use the original on_blast, but leave all other stealth nodes alone.

S-S-X commented 2 years ago

Maybe space cannon should use some node group ratings instead of https://github.com/pandorabox-io/spacecannon/blob/master/node_resilience.lua and then that group added for brc (or if there's already good widely used groups with usable ratings then just use those). There if main node does have custom on_blast then node resilience group rating should result in similar behavior.

But then I do also think stealth nodes should not be as hard as original nodes, however original nodes should for sure affect stealth node behavior so that brc stealth node is significantly harder to break than say cobble stone stealth node. Not sure if something like that is doable as generic function... maybe.

BuckarooBanzay commented 2 years ago

Short-term solution:

Long-term solution: