search

pandorabox-io / pandorabox_custom

pandorabox server customization mod
https://pandorabox.io
MIT License
4 stars 7 forks source link

more fish spawning heights #73

Closed SwissalpS closed 3 weeks ago

SwissalpS commented 2 months ago

proof of concept PR for basis of discussion.

closes https://github.com/pandorabox-io/in-game/issues/386

BuckarooBanzay commented 2 months ago

looks good, i wonder why the full world height is not the default though :thinking:

SwissalpS commented 2 months ago

looks good, i wonder why the full world height is not the default though 🤔

maybe because they are tropical fish. Then again, they do spawn in river water too.

SwissalpS commented 2 months ago

it is also easier to add more levels than to reduce them, so it seems OK for default to be conservative. (why I'm not PRing on 10+1's repo)

SwissalpS commented 3 weeks ago

hmm, almost forgot this one. No objections, so let's go with it.

BuckarooBanzay commented 3 weeks ago

hmm, almost forgot this one. No objections, so let's go with it.

is this ready or are more changes coming soon :thinking: (not that i don't want to merge this, it's just still in a draft mode :D)

SwissalpS commented 3 weeks ago

There was another comment on the discussion thread, so I marked this as draft again. Giving a chance for comments on my recent changes. I think we can merge now. Also it's not something that would be hard to undo/modify later.