search

pandusonu2 / MultiGameSet

Recreation of 13 in 1 game set from childhood
0 stars 3 forks source link

GSoC Heat project pull request #6

Closed sparshk closed 6 years ago

sparshk commented 6 years ago

The two classes Pieces and Table have been created. The Table class represents the chess board and the pieces. The Pieces class contains various methods such as getWSoldier(), getWBishop() etc. that return the respective image files to the assignTilePieceIcon() function of the sub-class TilePanel of the Table class.

nkprince007 commented 6 years ago

Also, running your code doesn't display the chess board as expected. So, I'm not even sure about the scope of this pull request.

pandusonu2 commented 6 years ago

Why are we doing separate getW() and getB() We can just pass an argument for the color

sparshk commented 6 years ago

It's indented properly in my IDE. But when I upload it on repo, it loses it's indentation. I couldn't understand why.

sparshk commented 6 years ago

When you run the table class, it does display the chess board with the pieces in their positions.

sparshk commented 6 years ago

I'll make the other changes and get back to you soon.

nkprince007 commented 6 years ago

Well, you should update the text panel on chess tab so that the pieces are displayed there in. Not in a different frame. About the indentation, you've mixed up tabs and spaces. To maintain consistency, follow whatever the other files are doing so.

sparshk commented 6 years ago

Okay. I'll update it. You've checked the chess board right?