Add spec parameter (Ready for Review)

panel-extensions / panel-graphic-walker

A project providing a Graphic Walker Pane for use with HoloViz Panel.

https://github.com/panel-extensions/panel-graphic-walker

MIT License

32 stars 3 forks source link

Add spec parameter (Ready for Review) #27

Closed MarcSkovMadsen closed 2 weeks ago

MarcSkovMadsen commented 3 weeks ago

Closes #https://github.com/panel-extensions/panel-graphic-walker/issues/7.

Todo:

[x] Implement, test and document
[ ] Philipp: read, address and close comments.
[ ] Philipp: Review and merge
[ ] Philipp: Release new version

Manual Test

Test via the app_demo.py file.

MarcSkovMadsen commented 3 weeks ago

This is ready for review. See todo list in top post.

MarcSkovMadsen commented 3 weeks ago

I added the earthquake "reference" example:

I have to set server_computation=True because I reach message limits - then it feels a bit sluggish.

MarcSkovMadsen commented 3 weeks ago

Just for the record. I tried to persist spec to url query args. But they will be too long for Microsoft edge. So its not a viable path to enable persisting app state for users:

https://github.com/Kanaries/graphic-walker/issues/420

MarcSkovMadsen commented 2 weeks ago

super seeded by #30