panel-extensions / panel-graphic-walker

A project providing a Graphic Walker Pane for use with HoloViz Panel.
https://github.com/panel-extensions/panel-graphic-walker
MIT License
32 stars 3 forks source link

Philipp: Dict of numpy array applies but does not work #8

Closed MarcSkovMadsen closed 2 weeks ago

MarcSkovMadsen commented 4 weeks ago

In the .applies function you signal that a dict of numpy arrays is supported. But it won't work in practice:

This fails

def test_constructor_with_dict_of_np_array():
    data = {
        "array1": np.array([1, 2, 3]),
        "array2": np.array([4, 5, 6]),
        "array3": np.array([7, 8, 9])
    }
    GraphicWalker(object=data)

    assert gwalker.object is data
    assert not gwalker.fields
    assert not gwalker.config
ValueError: DataFrame parameter 'ReactiveESMMetaclass.object' value must be an instance of DataFrame,
MarcSkovMadsen commented 2 weeks ago

Do you want to remove this functionality?

MarcSkovMadsen commented 2 weeks ago

Removed in https://github.com/panel-extensions/panel-graphic-walker/pull/22.