search

paneq / active_reload

Reload Rails code in development mode only when change is deteced
Other
371 stars 12 forks source link

incompatible with rails 3.2 #18

Open gucki opened 12 years ago

gucki commented 12 years ago

When migrating an old rails 3.1.x app to rails 3.2.0 assets are no longer served when active_reload is in the Gemfile (404 not found). This can easily by reproduced by creating a brand new 3.2 rails app and adding active_reload to the Gemfile.

As active_reload is not needed for rails 3.2 anymore, I'd suggest to put a big warning in the README making users aware of this bug/ problem. See this issues here too: https://github.com/rails/rails/issues/2715

mostlyobvious commented 12 years ago

Warning is already in README. It won't make any difference if it's any bigger when users are not willing to read it. Also since it's not needed in Rails 3.2, making it compatible is pointless.

mostlyobvious commented 12 years ago

I would however add rails dependency in limited version range to gemspec. It will at least prevent people from adding active_reload to gemfiles with rails 3.2.

gucki commented 12 years ago

Sorry, but I don't see any warning? Instead it tells me that I don't have to do anything (which is wrong):

This gem has been incorporated into Rails 3.2 which was my plan since the first release. If your are on Rails 3.2 you do not need to do anything. Also during that process Jose Valim fixed some bugs and added few useful features that it was missing. In other words, probably the easiest way to use it and have the best experience is to upgrade your Rails app.

I'd like to suggest to change this to something like this:

This gem is incompatbile with Rails 3.2 and needs to be removed from the Gemfile when upgrading. This has no drawbacks, because it has been incorporated into Rails 3.2 which was my plan since the first release. Also during that process Jose Valim fixed some bugs and added few useful features that it was missing. In other words, probably the easiest way to use it and have the best experience is to upgrade your Rails app.