search

paneron / dataset-build-action

GitHub action for building websites from datasets
0 stars 0 forks source link

How to pass scaffolding repository URL? #7

Closed strogonoff closed 2 years ago

strogonoff commented 2 years ago

For example, let’s look at https://github.com/paneron/iev-data-subset/blob/feature/migrate-to-gha/.github/workflows/deploy-master.yaml#L14.

That site should be built using https://github.com/paneron/glossary-site-scaffolding. However, where is that specified?

The idea is that the action should support a configuration option that would tell it which scaffolding template to use. The option can simply accept a URL to any Git repository with scaffolding, and use that URL to fetch scaffolding project code.

CAMOBAP commented 2 years ago

this configured in scaffolding input here https://github.com/paneron/dataset-build-action/blob/feature/first-release/build/action.yml#L4-L7

And default values is paneron/glossary-site-scaffolding

An explicit example is:

...
- uses: paneron/dataset-build-action/build@main
   with:
      scaffolding: paneron/glossary-site-scaffolding
...

At this point it expects only GitHub repos, but I can extend it if need

strogonoff commented 2 years ago

Got it.

On 5 Nov 2021, at 1:29 PM, Alex Bobrikovich @.***> wrote:

 this configured in scaffolding input here https://github.com/paneron/dataset-build-action/blob/feature/first-release/build/action.yml#L4-L7

And default values is paneron/glossary-site-scaffolding

An explicit example is:

...

  • uses: @.*** with: scaffolding: paneron/glossary-site-scaffolding ... At this point it expects only GitHub repos, but I can extend it if need

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

strogonoff commented 2 years ago

I don't think it should have a default, it should fail with error if no scaffolding repo is given, since it’s the key setting

On 5 Nov 2021, at 1:29 PM, Alex Bobrikovich @.***> wrote:

 this configured in scaffolding input here https://github.com/paneron/dataset-build-action/blob/feature/first-release/build/action.yml#L4-L7

And default values is paneron/glossary-site-scaffolding

An explicit example is:

...

  • uses: @.*** with: scaffolding: paneron/glossary-site-scaffolding ... At this point it expects only GitHub repos, but I can extend it if need

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

CAMOBAP commented 2 years ago

@strogonoff agree, I will fix this

strogonoff commented 2 years ago

Filed https://github.com/paneron/dataset-build-action/issues/8