pangenome / pggb

the pangenome graph builder
https://doi.org/10.1038/s41592-024-02430-3
MIT License
368 stars 41 forks source link

fatal error: ../include/wfmash_git_version.hpp: No such file or directory #150

Closed grenaud closed 2 years ago

grenaud commented 2 years ago

Hello! I am trying to build the package but I get:


/home/ctools/wfmash/src/version.cpp:10:10: fatal error: ../include/wfmash_git_version.hpp: No such file or directory
   10 | #include "../include/wfmash_git_version.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ekg commented 2 years ago

Is this via the docker build?

On Thu, Jan 6, 2022, 11:12 Gabriel Renaud @.***> wrote:

Hello! I am trying to build the package but I get:

/home/ctools/wfmash/src/version.cpp:10:10: fatal error: ../include/wfmash_git_version.hpp: No such file or directory 10 | #include "../include/wfmash_git_version.hpp" | ^~~~~~~~~~~

— Reply to this email directly, view it on GitHub https://github.com/pangenome/pggb/issues/150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEMBZYFQKBC2YP7DJ43UUVTKJANCNFSM5LL7JWCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

grenaud commented 2 years ago

No via cmake

AndreaGuarracino commented 2 years ago

Could you please report exactly all the instructions/steps you are following? Usually, we suggest users to install pggb with docker or bioconda.

ekg commented 2 years ago

It could be caused by building on a system without git. That file should contain a version string that is pulled from the git tree using the git CLI.

On Thu, Jan 6, 2022, 11:29 Andrea Guarracino @.***> wrote:

Could you please report exactly all the instructions/steps you are following? Usually, we suggest users to install pggb with docker or bioconda.

— Reply to this email directly, view it on GitHub https://github.com/pangenome/pggb/issues/150#issuecomment-1006454449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEP5CT6JI2FBXDVJU7DUUVVJXANCNFSM5LL7JWCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

grenaud commented 2 years ago

thank you for your quick answers! I did:

git clone https://github.com/ekg/wfmash.git cd wfmash/ mkdir build cd build/ cmake .. make -j 10

ekg commented 2 years ago

Looks like it could be a build dependency issue? That file should be created.

On Thu, Jan 6, 2022, 11:57 Gabriel Renaud @.***> wrote:

thank you for your quick answers! I did:

git clone https://github.com/ekg/wfmash.git cd wfmash/ mkdir build cd build/ cmake .. make -j 10

— Reply to this email directly, view it on GitHub https://github.com/pangenome/pggb/issues/150#issuecomment-1006475790, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQELDBV3IN7RSVZUPTBLUUVYQBANCNFSM5LL7JWCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

grenaud commented 2 years ago

Ok I fixed it by changing: execute_process(COMMAND bash scripts/generate_git_version.sh ${CMAKE_SOURCE_DIR}/include) to execute_process(COMMAND bash ../scripts/generate_git_version.sh ${CMAKE_SOURCE_DIR}/include)

AndreaGuarracino commented 2 years ago

@grenaud could you please retry with the current master? It should be fixed now.

AndreaGuarracino commented 2 years ago

Ok I fixed it by changing: execute_process(COMMAND bash scripts/generate_git_version.sh ${CMAKE_SOURCE_DIR}/include) to execute_process(COMMAND bash ../scripts/generate_git_version.sh ${CMAKE_SOURCE_DIR}/include)

Yes, it was exactly a path problem.

grenaud commented 2 years ago

@AndreaGuarracino I realized that I raised the issue on the wrong page. It should be on wfmash.

AndreaGuarracino commented 2 years ago

Do not worry. You would have encountered the same problem in the other components of pggb as well. I'm just fixing them all. Thank you for reporting this issue to us.