pangenome / pggb

the pangenome graph builder
https://doi.org/10.1101/2023.04.05.535718
MIT License
346 stars 37 forks source link

only fail if non-installed programs are required #390

Closed ASLeonard closed 3 months ago

ASLeonard commented 3 months ago

I (probably at my own peril) never use multiqc or deconstruct variants within my graph building pipelines, so don't have these tools installed. pggb runs fine without them, so hopefully this guards against errors when users do want those analyses but don't have the tools installed, but still leaves flexibility for others.

On a related note, I have wfmash etc compiled for our compute nodes which gives "illegal instruction" errors on our head nodes due to different architectures. The command -v wfmash returns happily saying it is installed but then the program just exits silently, not even creating the output directory. Something like wfmash --version catches this, but not all tools have that hook (like vcfwave), so this is probably a user problem rather than something pggb should handle gracefully.

AndreaGuarracino commented 3 months ago

Thanks, you anticipated me, I had the same problem xD