pangeo-data / climpred

:earth_americas: Verification of weather and climate forecasts :earth_africa:

https://climpred.readthedocs.io

MIT License

231 stars 48 forks source link

Prepare v2.4.0 #841

Closed Zeitsperre closed 11 months ago

Zeitsperre commented 11 months ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #839

Type of change

[x] Improved Documentation

Checklist (while developing)

[ ] CHANGELOG is updated with reference to this PR.

codecov[bot] commented 11 months ago

Codecov Report

Merging #841 (eda7728) into main (9afa5ce) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          59       59           
  Lines        6246     6246           
=======================================
  Hits         5730     5730           
  Misses        516      516

aaronspring commented 11 months ago

Thank you very much @mathause and @Zeitsperre

Zeitsperre commented 11 months ago

My pleasure! Just a small FYI: The practices in place require the following:

On tag: You and/or @bradyrx need to give the OK to deploy the package to TestPyPI
On Publish: You and/or @bradyrx need to give the OK to deploy the package to TestPyPI

This might be too many safeguards. If you want to remove the "staging" checks (disable review needed) that'll mean you'll only need to OK the PyPI deployment.

The true v2.4.0 release is waiting on the second approval: https://github.com/pangeo-data/climpred/actions/runs/6817795300

aaronspring commented 11 months ago

Second approval given

aaronspring commented 11 months ago

Remove reviewers from staging