Run deploy script for master/tag pushes

consideRatio commented 4 years ago

Followup #114. Yikes TravisCI isn't easy to get right, it is the shell scripting of CI/CD.

After introducing #114, I mistakenly restricted deployment script execution to when we push tags. This should make us run the deployment script for pushes to master as well as pushed tags.

jhamman commented 4 years ago

This seems to have deployed as pangeo-v0.2.2-n036.h48b31b2

consideRatio commented 4 years ago

v0.2.2-n036.h48b31b2 <--- this is the helm chart version.

v0.2.2 is the latest git tag
036 is the amount of commits since the latest git tag, prefixed with n (for the same reason as below)
48b31b2 is the latest commits hash (prefixed with h to ensure it never is purely numerical and starting with 0, because it will be invalid for Helm 3 then)

We should update chartpress to strip a v from the git-tag when creating the version, because if we don't it will make an invalid semver2 version, which makes it all Helm 3 incompatible.

pangeo-data / helm-chart

Run deploy script for master/tag pushes #117