pangeo-data / helm-chart

Pangeo helm charts
https://pangeo-data.github.io/helm-chart/
21 stars 26 forks source link

Add graphviz to notebook image #45

Closed martindurant closed 6 years ago

martindurant commented 6 years ago

Ref #43

OK, I was wrong, it still didn't work with those packages. Here I've gone back to apt-installing graphviz, and it now does render. The dependencies are pretty heavy, though - how would I measure the total size of the image, and how big is too big?

mrocklin commented 6 years ago

docker image list is informative

On Thu, Jul 5, 2018 at 5:12 PM, Martin Durant notifications@github.com wrote:

Ref #43 https://github.com/pangeo-data/helm-chart/issues/43

OK, I was wrong, it still didn't work with those packages. Here I've gone back to apt-installing graphviz, and it now does render. The dependencies are pretty heavy, though - how would I measure the total size of the image, and how big is too big?

You can view, comment on, or merge this pull request online at:

https://github.com/pangeo-data/helm-chart/pull/45 Commit Summary

  • Add graphviz to notebook image

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pangeo-data/helm-chart/pull/45, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszKT-5vHVZ-LXNvIpptRmFfUMcaeCks5uDoEjgaJpZM4VEjF- .

martindurant commented 6 years ago

Seems to make very little difference, which is perhaps puzzling

pangeo-notebook-master                          latest              bdccddd24992        5 seconds ago       2.82GB
pangeo-notebook-branch                          latest              a539590c543c        About an hour ago   2.89GB
mrocklin commented 6 years ago

Many system packages are quite small. The minimal debian docker image is around 100MB or something. In contrast, pandas is 80MB

On Thu, Jul 5, 2018 at 6:07 PM, Martin Durant notifications@github.com wrote:

Seems to make very little difference, which is perhaps puzzling

pangeo-notebook-master latest bdccddd24992 5 seconds ago 2.82GB pangeo-notebook-branch latest a539590c543c About an hour ago 2.89GB

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pangeo-data/helm-chart/pull/45#issuecomment-402866871, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszHIizeGmahtARW5TawP25Uw1RSF7ks5uDo4NgaJpZM4VEjF- .

mrocklin commented 6 years ago

Python package size is anomalous

On Thu, Jul 5, 2018 at 6:09 PM, Matthew Rocklin mrocklin@anaconda.com wrote:

Many system packages are quite small. The minimal debian docker image is around 100MB or something. In contrast, pandas is 80MB

On Thu, Jul 5, 2018 at 6:07 PM, Martin Durant notifications@github.com wrote:

Seems to make very little difference, which is perhaps puzzling

pangeo-notebook-master latest bdccddd24992 5 seconds ago 2.82GB pangeo-notebook-branch latest a539590c543c About an hour ago 2.89GB

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pangeo-data/helm-chart/pull/45#issuecomment-402866871, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszHIizeGmahtARW5TawP25Uw1RSF7ks5uDo4NgaJpZM4VEjF- .

martindurant commented 6 years ago

Debian is 45MB https://hub.docker.com/r/library/debian/tags/stable-20180625/ :)

jhamman commented 6 years ago

I'm in favor of giving this a try. For one, it would be nice to show off the dask task graphs in a demos/tutorials. Is the increase in image size a game changer here?

martindurant commented 6 years ago

@jhamman not at all! It was bigger than I expected, but insignificant compared to the overall size of the image.

jacobtomlinson commented 6 years ago

Let's go for it! I would agree that it is an important feature to have when you are frequently using dask.