search

pangeo-data / helm-chart

Pangeo helm charts
https://pangeo-data.github.io/helm-chart/
21 stars 26 forks source link

Don't create examples dir, git should do it #55

Closed martindurant closed 6 years ago

martindurant commented 6 years ago

Fixes #54

The original intent in #44 was not to over-write old examples directories predating the move to a separate git repo, but do update the directory if newer, only for those files which are in the repo. The pre-creation of the examples directory ( https://github.com/pangeo-data/helm-chart/blob/master/docker-images/notebook/Dockerfile#L84 and https://github.com/pangeo-data/helm-chart/blob/master/docker-images/notebook/Dockerfile#L85 ) broke this; but why was it working before?

martindurant commented 6 years ago

In addition, I could put in a rmdir examples to delete empty directories, for those that might happen to have them.

I still haven't figured out a way to test this. At the very least there ought to be a minimal QA every time that the image is updated, including, for this case, a test new-user.

martindurant commented 6 years ago

I guess the issue can stay open until the image is rebuilt, redeployed and tested manually.

rabernat commented 6 years ago

Thanks for addressing this quickly @martindurant! Really appreciate your contributions to this!

rabernat commented 6 years ago

I still haven't figured out a way to test this. At the very least there ought to be a minimal QA every time that the image is updated, including, for this case, a test new-user.

We need to start using the test cluster more systematically. Perhaps we can set that up today or tomorrow.