search

pangeo-data / helm-chart

Pangeo helm charts
https://pangeo-data.github.io/helm-chart/
21 stars 26 forks source link

Start with jupyter labhub #59

Closed jacobtomlinson closed 6 years ago

jacobtomlinson commented 6 years ago

The hub extension for Jupyter Lab checks whether you started the server with jupyter-labhub before displaying. We are still using the default jupyterhub-singleuser command from z2jh so the tab doesn't display.

As far as I can tell changing the start command doesn't affect anything. But I can now see the Hub tab!

image

rabernat commented 6 years ago

Looks great! Have you tested this?

jacobtomlinson commented 6 years ago

Yes on our Pangeo. I'm just moving this upstream.

jhamman commented 6 years ago

Yeah! Let's merge this in. Any ideas why this isn't passing the "push" build?

rabernat commented 6 years ago

The "push" builds always fail. They happen when you edit directly on github and create a new branch on the main repo.

rabernat commented 6 years ago

I think I will turn off "build pushed branches" on travis. Ok?

rabernat commented 6 years ago

I just deployed a new test cluster with the latest chart (which includes this PR), and I am not seeing the "hub" tab. Is there anything else that has to be done in order to enable it?

rabernat commented 6 years ago

Ah, I figure it out. I had to remove the line

    cmd: ['start-singleuser.sh']

from my jupyter-config.yaml. Now it works.