Closed jacobtomlinson closed 6 years ago
Looks great! Have you tested this?
Yes on our Pangeo. I'm just moving this upstream.
Yeah! Let's merge this in. Any ideas why this isn't passing the "push" build?
The "push" builds always fail. They happen when you edit directly on github and create a new branch on the main repo.
I think I will turn off "build pushed branches" on travis. Ok?
I just deployed a new test cluster with the latest chart (which includes this PR), and I am not seeing the "hub" tab. Is there anything else that has to be done in order to enable it?
Ah, I figure it out. I had to remove the line
cmd: ['start-singleuser.sh']
from my jupyter-config.yaml. Now it works.
The hub extension for Jupyter Lab checks whether you started the server with
jupyter-labhub
before displaying. We are still using the defaultjupyterhub-singleuser
command from z2jh so the tab doesn't display.As far as I can tell changing the start command doesn't affect anything. But I can now see the Hub tab!