search

pangeo-data / helm-chart

Pangeo helm charts
https://pangeo-data.github.io/helm-chart/
21 stars 26 forks source link

[WIP] remove notebook docker image #78

Closed jhamman closed 5 years ago

jhamman commented 5 years ago

This removes the docker image from this repo. This shouldNOT be merged until we have something like a pangeo-stacks repo in place.

cc @guillaumeeb

guillaumeeb commented 5 years ago

Linking to https://github.com/pangeo-data/pangeo/issues/525.

I'm perfectly fine with this, obviously. But let's build this other repo first 😃 !

jhamman commented 5 years ago

@guillaumeeb - I got a start here: https://github.com/pangeo-data/pangeo-stacks

We have a few things to sort out with repo2docker before this approach works.

jhamman commented 5 years ago

@guillaumeeb - care to take a look here again?

guillaumeeb commented 5 years ago

Is this currently plugged with one image built from https://github.com/pangeo-data/pangeo-stacks? (I don't think so, but just asking).

How and when do you plan to merge this?

We should probably add some comment somewhere, in the readme or directly in the chart, to inform that we are using images built from pangeo-stacks repo.

Other than that, I don't know what impacts the changes to the chartpress.yaml have...

jhamman commented 5 years ago

Is this currently plugged with one image built from https://github.com/pangeo-data/pangeo-stacks?

Yes, the pangeo/pangeo-notebook image is now on dockerhub and is built from this directory.

How and when do you plan to merge this?

Not sure I follow. Once @jacobtomlinson is also happy, I'll press the merge button :)

We should probably add some comment somewhere, in the readme or directly in the chart, to inform that we are using images built from pangeo-stacks repo.

I'll add some notes to the readme.