search

pangeo-data / jupyter-earth

Jupyter meets the Earth: combining research use cases in geosciences with technical developments within the Jupyter and Pangeo ecosystems.
https://jupytearth.org
Creative Commons Zero v1.0 Universal
28 stars 6 forks source link

Updates according to the JMTE Y3 report #149

Closed whyjz closed 1 year ago

whyjz commented 1 year ago

Also re-organized the Jupyter Book layout; add relevant external resources in the TOC.

@fperez what do you think about making the slides used in the 2022 EC workshop available to the public?

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

consideRatio commented 1 year ago

Using git blame I found this:

# sphinxcontrib-bibtex pinning reason: https://github.com/executablebooks/jupyter-book/issues/1137
sphinxcontrib-bibtex<2.0.0

I think maybe the use of this extension may need explicit configuration of where the .bib file is located. See https://github.com/executablebooks/jupyter-book/pull/1754/files.

I'm not sure why there are build errors, but since I see a very ancient pinning of a Python package, I assume that can be related. Let's try get that unpinned!

consideRatio commented 1 year ago

@whyjz I added the commit deae4d2 to this PR, which resolved the build failure!

whyjz commented 1 year ago

Thank you @consideRatio ! I was about the take a look today but realized you have beautifully solved the dependency issue. We are the best team!

whyjz commented 1 year ago

I will leave this PR open for one more day in case anyone wants to review it, then I will merge and publish the updates.

whyjz commented 1 year ago

Thanks Erik! I am running out of time today but will take a look tomorrow.

whyjz commented 1 year ago

@consideRatio I have done addressing your comments! For the quickstart section, yes, it is not finished yet, and we did not mention that in the Y3 report. So I just created another branch and moved the unfinished content there for another PR in the future.