Closed yuvipanda closed 1 year ago
Thank you for listing our your concerns, Erik! I will sort those out over the next few days!
@consideRatio gh-scoped-creds
is no longer installed as part of this repo, as it's now present in the base image. As such, I don't think a comment about that is relevant here anymore. The env config is part of the hub configuration, so I think it's ok it's just present in the infrastructure config.
I'll tackle the other items slowly over the course of this week.
With qgis, my goal is to replicate the work from https://github.com/CryoInTheCloud/hub-image here to the extent possible, as a lot of debugging and fine tuning went into that.
@consideRatio after spending some more time stepping back and thinking about it, I've come to conclude that maintaining huge all-in-one images is an antipattern I want to move away from. As such, I've opened https://github.com/2i2c-org/infrastructure/pull/2683 which provides more image choices for JMTE, and hopefully can deprecate this once I figure out how to provide missing functionality in other ways.
I'm going to close this PR now.
https://github.com/2i2c-org/infrastructure/issues/2583 is also related, on doing this systematically.