search

pangeo-data / pangeo-docker-images

Docker Images For Pangeo Jupyter Environment
https://pangeo-docker-images.readthedocs.io
MIT License
117 stars 90 forks source link

Release with jupyterhub 4.1+ #523

Closed consideRatio closed 3 months ago

consideRatio commented 3 months ago

JupyterHub 4.1 has been released and tested for a while, resulting in 4.1.4 and now been around without bugfixes requested for a week or so.

When jupyterhub-singleuser 4.1.4 is part of the image, it changes the requirements on some interactions where javascript api requests are made to the jupyter_server. These requirements could require updates to software like nbgitpuller (compatible with 1.2.1) that from a browser's view interacts with the jupyter server via javascript requests.

There could be software in these images that still needs to be made compatible with jupyterhub-singleuser 4.1.4, but I'm not aware of any currently.

jhamman commented 3 months ago

@consideRatio - should we expect any compatibility issues with daskhub deployments here?

consideRatio commented 3 months ago

No dask-gateway issues expected - tested! (EDIT: updated language for clarity)

consideRatio commented 3 months ago

2024.03.30 is released to include jupyterhub 4.1 and nbgitpuller 1.2.1 which is compatible - be on the lookout for issues related to javascript API requests to user servers or jupyterhub when used with jupyterhub - specifcally about missing XSRF tokens etc.

There is no known issue, but there could be yet to be discovered issues.

consideRatio commented 3 months ago

Ping @scottyhq for visibility - jupyterhub 4.1.4 is used in 2024.03.30 now - which could bring xsrf issues and require updates in misc packages, for example nbgitpuller which is already patched, when using this image in a as a jupyterhub user server.