pangeo-data / pangeo-docker-images

Docker Images For Pangeo Jupyter Environment
https://pangeo-docker-images.readthedocs.io
MIT License
117 stars 90 forks source link

Checking for bokeh static files raises error when building on mybinder.org #530

Closed scottyhq closed 3 months ago

scottyhq commented 3 months ago

Describe the bug

/bin/sh: 1: [: /srv/conda/envs/notebook/lib/python3.1/site-packages/bokeh/server/static: unexpected operator

Noticed here #522

Seems to be a problem with variable expansion and wildcard in this directory check, possible related to 3.1 -> 3.10 conda symlink... https://github.com/pangeo-data/pangeo-docker-images/blob/6582f8aa8f0724dd127026b01da3bdf71a60a4fb/base-image/Dockerfile#L172

I guess nobody has been using binder for a few years since the binder build fails but building locally or on github actions does not raise this error. For example, log from the last merged PR: https://github.com/pangeo-data/pangeo-docker-images/actions/runs/8494705937/job/23270196870#step:7:179

Docker Image Version 2024.03.22 (although has probably been the case for a while). This results in ~30MB static bokeh .js files not being deleted to reduce the image size

30M /srv/conda/envs/notebook/lib/python3.11/site-packages/bokeh/server/static