pangeo-data / pangeo-docker-images

Docker Images For Pangeo Jupyter Environment
https://pangeo-docker-images.readthedocs.io
MIT License
117 stars 90 forks source link

Publish CalVer tags for linux/arm64 platform builds #564

Closed weiji14 closed 1 day ago

weiji14 commented 2 days ago

The base-image, base-notebook and pangeo-notebook Docker images only had linux/amd64 platform available on the latest and CalVer tags (see e.g. pangeo-notebook:2024.06.28), whereas the master tag has both linux/amd64 and linux/arm64:

image

Need to use the --platform flag when doing docker pull or docker push, so that the linux/arm64 images will be made available for latest and Calver tags.

Patches #399

github-actions[bot] commented 2 days ago

Binder :point_left: Try on Mybinder.org!

weiji14 commented 2 days ago

I haven't tested this, but you can merge this in @scottyhq and tag a new version to see if it works.

scottyhq commented 14 hours ago

This didn't quite work... But fortunately it's okay to break things ;)

I think this is what we need to do: https://github.com/docker/buildx/issues/1744#issuecomment-1896645786

# TAG -> master -> date / latest
docker buildx imagetools create pangeo/base-image:master -t pangeo/base-image:latest -t pangeo/base-image:2024.07.02

docker buildx imagetools create quay.io/pangeo/base-image:master -t quay.io/pangeo/base-image:latest -t quay.io/pangeo/base-image:2024.07.02

This also looks useful! https://github.com/regclient/regclient

scottyhq commented 13 hours ago

:rocket: Fixed for images>2024.07.02 https://github.com/pangeo-data/pangeo-docker-images/actions/runs/9767498538

weiji14 commented 11 hours ago

Ah nice, that docker buildx method looks much cleaner, less lines of code to deal with! Which reminds me, maybe we should revisit buildx a bit more, xref #357.