search

pangeo-data / pangeo-stacks

Curated Docker images for use with Jupyter and Pangeo
https://pangeo-data.github.io/pangeo-stacks/
BSD 3-Clause "New" or "Revised" License
17 stars 20 forks source link

fix onbuild images with new 'start' script entrypoint in r2d_overlay #123

Closed scottyhq closed 4 years ago

scottyhq commented 4 years ago

hopefully closes https://github.com/pangeo-data/pangeo-stacks/issues/122

doing a little forensics it seems that this merge https://github.com/pangeo-data/pangeo-stacks/commit/f493076f5a5d40fb5ab9c7b650db874fa3171f23

did not include all the needed changes which were merged to the forked master branch but not the branch of the PR! https://github.com/scollis/pangeo-stacks/pull/1

scottyhq commented 4 years ago

incorporated these changes in this PR https://github.com/pangeo-data/pangeo-stacks/pull/118 and did a quick test https://github.com/scottyhq/pangeo-binder-test to confirm new images work