search

pangeo-data / pangeo-stacks

Curated Docker images for use with Jupyter and Pangeo
https://pangeo-data.github.io/pangeo-stacks/
BSD 3-Clause "New" or "Revised" License
17 stars 20 forks source link

Fix onbuild images to prevent resolving environment when launched with binder #135

Closed scottyhq closed 4 years ago

scottyhq commented 4 years ago

seems like this line got removed by accident in PR related to implementing the start sidecar file.

hopefully fixes https://github.com/pangeo-data/pangeo-stacks/issues/134

@rabernat, @yuvipanda, @tjcrone

yuvipanda commented 4 years ago

I like it!

yuvipanda commented 4 years ago

Unless this was causing it to be confused about 'start' and thus making the tests fail, in which case I don't like it.

We shall watch the test and see, I guess!

yuvipanda commented 4 years ago

@scottyhq I can't seem to find it - is there a test for 'start'? If this doesn't break 'start', it's good to go I think.

scottyhq commented 4 years ago

I don't think we have a test for start :( ... if you have a recommendation I can add something. Maybe just confirming an environment variable gets set? with docker run ? https://github.com/pangeo-data/pangeo-stacks/tree/master/pangeo-notebook/binder/tests