pangeo-data / pangeo

Pangeo website + discussion of general issues related to the project.
http://pangeo.io
701 stars 189 forks source link

Remove old and unsupported sphinx GHA #913

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

Nothing to see here (yet). Just testing if we can fix the docs build and/or update the sphinx build here.

This one is ready for review.

ocefpaf commented 1 year ago

@paigem this improves a bit the doc situation here by:

That last step is odd b/c the current approach doesn't error out on it but I could not get an error free build with rstjinja. I'm not sure that is actually used so we need input from the folks that implemented that to be sure we can remove it. It was added in https://github.com/pangeo-data/pangeo/pull/293

Or, maybe there is just a malformed jinja somewhere and rstjinja is working as expected, not sure.

TL;DR this is not ready for merging :grimacing:

ocefpaf commented 1 year ago

OK, the problem was not rstjinja but a double documented file, the hpc.md and hpc.rst. I removed the md version and, if that is OK, this PR is ready for review.

TomAugspurger commented 1 year ago

Thanks @ocefpaf! It does look like sphinx-problem-matcher is working: https://github.com/pangeo-data/pangeo/pull/913/files#diff-9956fdac1df3f4fd0af96bed18d51583a4ab55b933b4efb6a91999f4fb4698a9 (nothing too serious, so we can fix those later).