pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Tutorial.ipynb update #122

Closed norlandrhagen closed 1 year ago

norlandrhagen commented 2 years ago

Reran tutorial.ipynb with rechunker version 0.5 to remove copy_chunk_output messages in the documentation.

ex:


_copy_chunk((slice(0, 100, None), slice(0, 25, None), slice(0, 53, None)))
_copy_chunk((slice(100, 200, None), slice(0, 25, None), slice(0, 53, None)))
_copy_chunk((slice(200, 300, None), slice(0, 25, None), slice(0, 53, None)))
etc..```
review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

rabernat commented 1 year ago

Thanks for this contribution @norlandrhagen and sorry for letting it lie stagnant for so long. I'll try to figure out what's up with the failing tests.

codecov[bot] commented 1 year ago

Codecov Report

Merging #122 (9281d4b) into master (46db807) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          11       11           
  Lines         548      548           
  Branches      105      100    -5     
=======================================
  Hits          528      528           
  Misses         13       13           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rabernat commented 1 year ago

I think I can merge this. Sorry for letting it linger so long.

We can ignore the failing test. Beam is broken with python 3.10. (See https://github.com/pangeo-forge/pangeo-forge-recipes/pull/470).

norlandrhagen commented 1 year ago

No worries at all @rabernat!