pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
162 stars 25 forks source link

Modernize the packaging of rechunker a bit #138

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

This should also make releasing a bit simpler. Just a GH tag, using the web interface.

codecov[bot] commented 1 year ago

Codecov Report

Merging #138 (63887a9) into master (d625b6d) will decrease coverage by 26.36%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #138       +/-   ##
===========================================
- Coverage   96.38%   70.03%   -26.36%     
===========================================
  Files          11       11               
  Lines         554      554               
  Branches      106      106               
===========================================
- Hits          534      388      -146     
- Misses         13      149      +136     
- Partials        7       17       +10     
Impacted Files Coverage Δ
rechunker/algorithm.py 91.22% <ø> (ø)
rechunker/api.py 66.66% <ø> (-30.56%) :arrow_down:

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

ocefpaf commented 1 year ago

I'll stop here and address the documentation in a fresh PR to avoid making this one too big. We need to update the API rst files or, better yet, autogenerate them, and decide on what to do with the tutorial.ipynb parts that are not executed (I kept it like it was before).

PS: I suggest to remove the reviewnb app now that GH has a notebook diff. They look really nice:

Screenshot from 2023-03-14 16-12-54