search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
162 stars 25 forks source link

Remove wildcard rm from tutorial #151

Closed Quba1 closed 1 month ago

Quba1 commented 2 months ago

The Toy tutorial guides the user to execute rm -rf *.zarr, which I find a little bit dangerous for the user.

Someone carefully following the tutorial is likely to be inexperienced user, possibly without much experience with Linux. If such a user runs the tutorial in the same directory as they store zarr data they might end up deleting all their data.

As by that point the tutorial does not produce any data, running rm -rf *.zarr seems like an excessive precaution. Therefore, I would like to suggest removing this command from tutorial.

If you don't agree with my reasoning - feel free to close this PR.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

TomAugspurger commented 2 months ago

Makes sense.

I think that previously we ran into issues with rechunker failing when some intermediate or output files were present. Can you try running the tutorial twice in the same directory (without the rm -rf)?