search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Remove 'thunk' jargon from PythonExecutor #33

Closed shoyer closed 4 years ago

shoyer commented 4 years ago

there's no really any need to introduce the "thunk" name here: https://en.wikipedia.org/wiki/Thunk

codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.76%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   91.57%   92.33%   +0.76%     
==========================================
  Files           5        5              
  Lines         273      274       +1     
  Branches       57       57              
==========================================
+ Hits          250      253       +3     
+ Misses         11       10       -1     
+ Partials       12       11       -1
Impacted Files Coverage Δ
rechunker/executors/python.py 100.00% <100.00%> (ø)
rechunker/api.py 90.26% <0.00%> (+0.08%) :arrow_up:
rechunker/algorithm.py 84.61% <0.00%> (+3.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 721c601...ee0f28a. Read the comment docs.

rabernat commented 4 years ago

Thanks for doing this Stephan. And sorry if I merged your other PR prematurely.

shoyer commented 4 years ago

no worries, I think it was pretty much good to go :)