search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Add Prefect executor #37

Closed rabernat closed 4 years ago

rabernat commented 4 years ago

Thanks to three the nice Executor examples @shoyer already wrote, I was able to write a Prefect Executor in less than an hour. It seems to work!

codecov[bot] commented 4 years ago

Codecov Report

Merging #37 into master will decrease coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   93.55%   93.46%   -0.10%     
==========================================
  Files           7        8       +1     
  Lines         326      352      +26     
  Branches       66       70       +4     
==========================================
+ Hits          305      329      +24     
- Misses         10       11       +1     
- Partials       11       12       +1
Impacted Files Coverage Δ
rechunker/api.py 90.98% <100.00%> (+0.22%) :arrow_up:
rechunker/executors/prefect.py 100.00% <100.00%> (ø)
rechunker/algorithm.py 81.53% <0.00%> (-3.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 685a8b2...2af8fd0. Read the comment docs.

TomAugspurger commented 4 years ago

Updated for the new data model. @shoyer can you glance at https://github.com/pangeo-data/rechunker/pull/37/commits/2d2dcb8b0cce485287312671a28269cffc96e134 and let me know if it looks reasonable?

@rabernat you'll probably want to test this again after my changes.

TomAugspurger commented 4 years ago

I think the coverage failure can be ignored.