search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

update for executors, prep for 0.2 #43

Closed TomAugspurger closed 4 years ago

TomAugspurger commented 4 years ago

Planning to tag 0.2.0 after merging.

codecov[bot] commented 4 years ago

Codecov Report

Merging #43 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          10       10           
  Lines         392      392           
  Branches       75       75           
=======================================
  Hits          372      372           
  Misses         10       10           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7a75c9...8675ac3. Read the comment docs.

rabernat commented 4 years ago

I was about to comment on this. Do we ever provide this decoding anywhere in the docs:

https://github.com/pangeo-data/rechunker/blob/12b9a05dd1c4855968e5c36ff00a334749b9f7e9/rechunker/api.py#L149-L173

I think not.

rabernat commented 4 years ago

It's not in the API docs, for the rechunk function: https://rechunker.readthedocs.io/en/latest/api.html#rechunk-function

TomAugspurger commented 4 years ago

I'll add a note. Best place is probably in rechunker.rechunk?