search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Use pre-commit in build instead of calling flake8/black #49

Closed eric-czech closed 4 years ago

eric-czech commented 4 years ago

Is there any reason that the pre-commit hook isn't run as part of the build rather than by calling the same steps directly? I'm looking at: https://github.com/pangeo-data/rechunker/blob/b3e9628b0578472f6cfb55be79e2eabb504ba2b6/.github/workflows/ci.yaml#L43-L48

The build in https://github.com/pangeo-data/rechunker/pull/48 is (I think) failing because the pre-commit hook I ran locally is pinned to black 19.10b0 while the ci run is using the latest version (20.8b1).

TomAugspurger commented 4 years ago

Closed by #50