search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

simplify tests #60

Closed ocefpaf closed 3 years ago

ocefpaf commented 3 years ago

I was reading the tests to understand this part and it got confusing with the duplication. Of that was intentional b/c those args may change in the future please just close this. If not, this PR consolidate the common ones and then just update what is different for each case.

codecov[bot] commented 3 years ago

Codecov Report

Merging #60 into master will decrease coverage by 0.44%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   97.75%   97.30%   -0.45%     
==========================================
  Files          10       10              
  Lines         445      445              
  Branches       88       88              
==========================================
- Hits          435      433       -2     
- Misses          5        7       +2     
  Partials        5        5
Impacted Files Coverage Δ
rechunker/executors/pywren.py 94.28% <0.00%> (-5.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f49f96...10b50c9. Read the comment docs.

TomAugspurger commented 3 years ago

Looks good, thanks. I think that the codecov failure can be ignored.