Closed andrewbrettin closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Merging #61 into master will increase coverage by
0.21%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 97.30% 97.52% +0.21%
==========================================
Files 10 10
Lines 445 444 -1
Branches 88 88
==========================================
Hits 433 433
+ Misses 7 6 -1
Partials 5 5
Impacted Files | Coverage Δ | |
---|---|---|
rechunker/compat.py | 88.88% <0.00%> (-11.12%) |
:arrow_down: |
rechunker/api.py | 100.00% <0.00%> (ø) |
|
rechunker/executors/pywren.py | 100.00% <0.00%> (+5.71%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fcc5178...3acbd8d. Read the comment docs.
Hi @andrewbrettin -- thanks so much for this PR! Yes, we recently changed the API (see #48). Thanks for updating the tutorial. And sorry for not responding for a while. The past few weeks have been a bit distracting, to say the least. 😉
Correct me if I'm wrong, but I think the function call in the rechunker API requires temp_store to be a keyword arg if 'target_options' is unspecified?
Also, apologies if I'm not following the contributing guidelines - I am new to pull requests!