search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Fix null temp #74

Closed lsetiawan closed 3 years ago

lsetiawan commented 3 years ago

Overview

Similar to #59. I encountered the error when trying to rechunk from a zarr store to zarr store on the cloud using fsspec mapper. This PR works in the same exact way as PR #64, but with direct zarr store to zarr store rechunking rather than from dataset. It seems like current test doesn't capture this case.

codecov[bot] commented 3 years ago

Codecov Report

Merging #74 (b090597) into master (15f7e31) will increase coverage by 0.44%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   97.31%   97.76%   +0.44%     
==========================================
  Files          10       10              
  Lines         447      447              
  Branches       89       89              
==========================================
+ Hits          435      437       +2     
+ Misses          7        5       -2     
  Partials        5        5
Impacted Files Coverage Δ
rechunker/api.py 100.00% <100.00%> (ø)
rechunker/executors/pywren.py 100.00% <0.00%> (+5.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15f7e31...b090597. Read the comment docs.

rabernat commented 3 years ago

Fantastic, thanks so much for this fix!