search

pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Rechunker 0.4 requires Dask and Prefect #82

Closed tomwhite closed 3 years ago

tomwhite commented 3 years ago

It looks like the changes in #77 mean that Prefect (and Dask) are now required, which seems like an inadvertent change.

I noticed this in https://github.com/pystatgen/sgkit/issues/530.

TomAugspurger commented 3 years ago

Agreed, that wasn't intentional.

Do we just need to make the prefect import at https://github.com/pangeo-data/rechunker/pull/77/files#diff-3dfce265445fa41c7ca0059e55990be70becc0eacead2d147ee39840fba1db27R1-R3 lazy / put in a try / except block?

rabernat commented 3 years ago

Hi folks, I did this release just before vacation. Sorry for the glitch. I'll push a fix and do a new release asap.

rabernat commented 3 years ago

Rechunker 0.4.1 is now on pypi. @tomwhite, do you want to confirm that it actually resolves your original problem? #85 was a quick fix and doesn't actually explicitly test that you can import rechunker without the optional dependencies.

tomwhite commented 3 years ago

Unfortunately #85 didn't fix the issue. I've opened #87 which fixes the issue.

85 was a quick fix and doesn't actually explicitly test that you can import rechunker without the optional dependencies.

It would be good to add such a test if someone has time.

rabernat commented 3 years ago

Ok thanks for checking. Should we also revert #85?

rabernat commented 3 years ago

Ok hopefully 0.4.2 does the trick 😉 ! Thanks for your patience with this error and for your help fixing my mistake.

FWIW, dask[array] has been a required dependency for a while: https://github.com/pangeo-data/rechunker/blob/40f2aa945cce73dea7e5239434016f7ed55218a6/setup.py#L10