pangeo-data / rechunker

Disk-to-disk chunk transformation for chunked arrays.
https://rechunker.readthedocs.io/
MIT License
163 stars 25 forks source link

Mark a test as requiring prefect #88

Closed shoyer closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #88 (2a9ca9b) into master (40f2aa9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          12       12           
  Lines         515      515           
  Branches       93       93           
=======================================
  Hits          498      498           
  Misses         11       11           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40f2aa9...2a9ca9b. Read the comment docs.

rabernat commented 3 years ago

Thanks @shoyer!

In #82 we found ourselves wishing we had CI environments that tested more limited versions of dependencies (e.g. no prefect, no beam). Could I convince you to add such an environment in this PR to so we can verify that the tests are if fact being skipped as expected (rather than erroring)?

shoyer commented 3 years ago

I'd love to, but I'm not sure when I'll have time for that...

On Wed, Apr 28, 2021 at 10:59 AM Ryan Abernathey @.***> wrote:

Thanks @shoyer https://github.com/shoyer!

In #82 https://github.com/pangeo-data/rechunker/issues/82 we found ourselves wishing we had CI environments that tested more limited versions of dependencies (e.g. no prefect, no beam). Could I convince you to add such an environment in this PR to so we can verify that the tests are if fact being skipped as expected (rather than erroring)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pangeo-data/rechunker/pull/88#issuecomment-828661785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVXAIJ55BDPV4J3RI6LTLBEI7ANCNFSM43XRI6UQ .

shoyer commented 3 years ago

I went ahead and added another CI environment with minimal test dependencies.