search

pangeo-data / scikit-downscale

Statistical climate downscaling in Python
https://scikit-downscale.readthedocs.io/en/latest/
Apache License 2.0
185 stars 47 forks source link

Proper scikit-learn compatibility checks (and fixes) for pointwise models #43

Closed jhamman closed 4 years ago

jhamman commented 4 years ago

Scikit-learn has a few conventions around third party estimators. To date, I've played the compatibility claim pretty fast and loose with regard to pointwise models and inheritance of scikit-learn base classes. This PR adds a specific check to all estimators to ensure compatibility and tries to fix as many issues as possible. Here goes nothing...

Rolling your own estimator: https://scikit-learn.org/stable/developers/develop.html#rolling-your-own-estimator