pangeo-data / scikit-downscale

Statistical climate downscaling in Python

https://scikit-downscale.readthedocs.io/en/latest/

Apache License 2.0

185 stars 47 forks source link

Feature/add spatial disaggregation recipe #57

Open dgergel opened 3 years ago

dgergel commented 3 years ago

This PR adds the following:

1) a full recipe for implementing the Thrasher et al. 2012 method for spatial disaggregation that is part of the Bias Correction and Spatial Disaggregation (BCSD) daily downscaling method 2) structure for a new class of spatial models 2) a fit/predict method for spatial disaggregation using the SpatialDisaggregator class in spatial models

jhamman commented 3 years ago

@dgergel - I just merged some changes in that should fix the CI for you. Go ahead and pull those in and then I'll take a look here.

dgergel commented 3 years ago

@jhamman sorry for the delay in fixing the pre-commit problems. This is finally ready for a review.

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (098d8ea) into main (8a0c27e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 098d8ea differs from pull request most recent head 458f292. Consider uploading reports for the commit 458f292 to get more accurate results

@@    Coverage Diff     @@
##   main   #57   +/-   ##
==========================
==========================

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a0c27e...458f292. Read the comment docs.

dgergel commented 3 years ago

@jhamman so sorry for taking so long to get back to this. I've made the changes you suggested and added unit tests, so this is ready for another review.