search

pangeo-data / swot_adac_ogcms

Documentation and notebooks for the SWOT Adopt-a-Crossover Model Intercomparison
Apache License 2.0
9 stars 3 forks source link

Add validation, update recommended loading in notebook #5

Closed cisaacstern closed 2 years ago

cisaacstern commented 3 years ago

@roxyboy, lots of cool developments here.

  1. ORCA is online
  2. I rewrote validate_catalog.py so that it actually validates every one of our datasets. (And running it caught a few mistakes I'd made in the catalog, which I then corrected!)
  3. I then totally rewrote intake_demo.ipynb to take advantage of the parametrization logic in validate_catalog.py.

A bit more about the intake_demo.ipynb rewrite. Valid intake catalog parameters vary somewhat from model to model. FESOM doesn't have a region parameter, for example, and not all models have a grid on the cloud. This could be because some params are truly irrelevant for a particular model, or in certain cases it's just because we haven't gotten the data yet.

So to make it crystal clear, I've taken advantage of the existing logic in validate_catalog.py to import a nested dictionary into intake_demo.ipynb which tells you exactly the set of catalog parameters that are valid for each model. Instead of manually entering the catalog params, you can now load directly using one of these pre-defined parameterizations.

Does the new intake_demo.ipynb make sense? Happy to rework to make the loading more intuitive based on your feedback.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

roxyboy commented 3 years ago

Sorry for my belated response. I just came back from vacation.

cisaacstern commented 2 years ago

@roxyboy, I'm about to push updates to the catalog for the new FESOM data...

...so going to merge this so we can keep moving forward.

If you have lingering questions related to https://github.com/pangeo-data/swot_adac_ogcms/pull/5#discussion_r690548779 let's open a new issue to discuss.