pangeo-data / xESMF

Universal Regridder for Geospatial Data
http://xesmf.readthedocs.io/
MIT License
183 stars 32 forks source link

try importing esmpy (aliased to ESMF) for esmpy >= 8.4.0 fixes #212 #214

Closed raphaeldussin closed 1 year ago

raphaeldussin commented 1 year ago

fall back on old name if the import fails

raphaeldussin commented 1 year ago

@aulemahal I'm getting the test failing for the spatialAverager with AttributeError: 'CoordinateSequence' object has no attribute 'array_interface'

can you take a look?

aulemahal commented 1 year ago

That's shapely 2.0... ugh...

Pinning it to < 2.0 should work for now. I'll look into it and try to push a fix.

raphaeldussin commented 1 year ago

ok I'll put a pin for now before we get flooded with broken installs with the new esmpy

raphaeldussin commented 1 year ago

fixes #212

this is ready for review (then squash and merge) and somewhat time sensitive.

huard commented 1 year ago

Just add a note to CHANGES about this.