search

pangeo-data / xESMF

Universal Regridder for Geospatial Data
http://xesmf.readthedocs.io/
MIT License
183 stars 32 forks source link

Added Typing #311

Closed Siddhesh-Agarwal closed 3 months ago

Siddhesh-Agarwal commented 8 months ago
huard commented 8 months ago

Thanks! I've asked a colleague to provide a review.

Siddhesh-Agarwal commented 8 months ago

@charlesgauthier-udm I have completed the changes mentioned in the previous review. I hope these are up to your expectations.

huard commented 8 months ago

Please resolve the test failures then this is ready to merge.

Siddhesh-Agarwal commented 7 months ago

@huard, it is insane to have these many pre-commit hooks. Black, Isort, and flake8 seem fine but now prettier? I am sorry but I will have to leave this PR in this state.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

huard commented 7 months ago

Hi @Siddhesh-Agarwal

Once installed locally, pre-commit will run before each commit, so this is not something you're expected to worry about and do "by-hand".

I'm now working to address the remaining issues. I realized that by pushing to this PR, I'm pushing to your master, which might interfere with your work. Please open a PR in a separate branch to avoid this in the future.

huard commented 7 months ago

There are a couple of failures still remaining, but I'm stumped about what might cause them.