pangeo-data / xESMF

Universal Regridder for Geospatial Data
http://xesmf.readthedocs.io/
MIT License
182 stars 32 forks source link

Upstream CI failure - xarray update #338

Closed aulemahal closed 4 months ago

aulemahal commented 4 months ago

https://github.com/pangeo-data/xESMF/actions/runs/7880164199

Test failures triggered by some changes in xarray regarding the xr.core.pycompat submodule.

On the other hand, the last run was made with ESMF 8.6, and it seems like no errors were related to this long awaited upgrade!

TomNicholas commented 4 months ago

Wait why are you guys using xarray.core.pycompat? Anything in core is not public API, and therefore liable to change at any time...

aulemahal commented 4 months ago

Hmm, seems it is only used for the is_dask_collection method, I guess it was overlooked when implementing that code...