Remove function from private xarray module

pangeo-data / xESMF

Universal Regridder for Geospatial Data

http://xesmf.readthedocs.io/

MIT License

182 stars 32 forks source link

Remove function from private xarray module #340

Closed aulemahal closed 4 months ago

aulemahal commented 4 months ago

Fixes #338

We were using a method from xr.core.pycompat that was removed. That module is private, so this was a mistake on our end.

Also, the method was only used to check if a dataArray was dask-backed and load it if it was. However, calling load() on any array has the exact same effect anyway.

Seeing how this impacted downstream packages, this might warrant a minor or patch release!

TomNicholas commented 4 months ago

Another option is to just copy the original code for is_dask_collection from xarray into xESMF if you really need it.

aulemahal commented 4 months ago

Hum, turns out cf-xarray has the same issue! I'll open a PR and issue.

aulemahal commented 4 months ago

See https://github.com/xarray-contrib/cf-xarray/pull/502

aulemahal commented 4 months ago

To trigger tests again.