Fix parallel regridder regression and version 0.8.4

pangeo-data / xESMF

Universal Regridder for Geospatial Data

http://xesmf.readthedocs.io/

MIT License

182 stars 32 forks source link

Fix parallel regridder regression and version 0.8.4 #344

Closed aulemahal closed 4 months ago

aulemahal commented 4 months ago

Another patch release for a quick fix.

Fixes #343 by skipping the rename if the coordinate has the same name as a dimension, in which cas renaming has already been done. I also added a test of the parallel regridder for that case.

We didn't catch that because our test dataset is "curvilinear", i.e. the dimensions are different from the coords (which are 2D). The bug was affecting rectilinear datasets (coords == dims, both 1D).

Finally, I removed a duplicated in the CHANGES.

aulemahal commented 4 months ago

No! Too fast haha.

raphaeldussin commented 4 months ago

oops!