pangeo-forge / dataflow-status-monitoring

GCP Resources to report the status of completed Dataflow jobs.
3 stars 0 forks source link

Use generated log sink account to avoid organization domain restrictions. #3

Closed sharkinsspatial closed 2 years ago

cisaacstern commented 2 years ago

I've now

  1. Torn down resources deployed yesterday from main
  2. Manually removed the service account permissions I assigned to make those resources work
  3. Re-deployed the resources from this branch, which succeeded without error

I'll now see about triggering an invocation by calling a recipe test on https://github.com/pangeo-forge/staged-recipes/pull/138

cisaacstern commented 2 years ago

I'll now see about triggering an invocation by calling a recipe test on https://github.com/pangeo-forge/staged-recipes/pull/138

@sharkinsspatial, the infrastructure defined in this PR (which I've just deployed to GCP with no manual tweaks whatsoever), appears to work perfectly, as evidenced by https://github.com/pangeo-forge/staged-recipes/pull/138#issuecomment-1170382523

So IMHO we can merge this.

cisaacstern commented 2 years ago

Found another bug I'd like to address, so rather than having two PRs open at once, I'm going to merge this, since it looks like it works as intended. Thanks for this awesome work, @sharkinsspatial!