search

pangeo-forge / gpcp-feedstock

A Pangeo Forge Feedstock for gpcp.
Apache License 2.0
3 stars 2 forks source link

Use current year in range #7

Open wolfv opened 2 years ago

pangeo-forge-bot commented 2 years ago

:tada: New recipe runs created for the following recipes at sha 4822edd3a49a1513df2157e89457ca3f879478de:

cisaacstern commented 1 year ago

Thanks for the engagement here, @wolfv! There was presumably a conversation with @rabernat at SciPy that led to this, which I missed, so apologies if this was already discussed.

Based on chatting with @yuvipanda about static vs. dynamic date ranges in recipes just now, I wonder if we actually prefer to have static date ranges, which would ensure that the dataset built by a given recipe at a given commit is deterministic, regardless of when the code is imported and run. In the dynamic generation case, the date of execution affects the built dataset, which perhaps limits recipe reproducibility?

Curious to know others' thoughts on this!

wolfv commented 1 year ago

@cisaacstern maybe you should create a overrideable datetime function in pangeo_forge helpers? So that the date can be easily overriden with some saved state.

E.g. the function could check if there is a environment variable called PANGEO_FORGE_DATE=2022-02-02 and then internally make a datetime.date object out of that.