search

pangeo-forge / noaa-coastwatch-geopolar-sst-feedstock

A Pangeo Forge Feedstock for noaa-coastwatch-geopolar-sst.
Apache License 2.0
0 stars 0 forks source link

Install pangeo-forge-recipes from branch `@prefect-retry` #3

Closed cisaacstern closed 2 years ago

cisaacstern commented 2 years ago

This PR directs Pangeo Forge Cloud (specifically, the Registrar) to install pangeo-forge-recipes from the @prefect-retry branch on GitHub, which has the following diff with the default branch:

https://github.com/pangeo-forge/pangeo-forge-recipes/compare/master..prefect-retry

The purpose of this branch is to see if using retries will resolve the timeout errors we saw on the first production run of this feedstock. To support installing from GitHub branches, I've also pushed https://github.com/pangeo-forge/registrar/pull/26 to Docker Hub.

xref https://github.com/pangeo-forge/noaa-coastwatch-geopolar-sst-feedstock/issues/2#issuecomment-1102950710

pangeo-forge-bot commented 2 years ago

It looks like there may be a problem with the structure of your PR.

I encountered a FilesChangedOutsideRecipesSubdirError('This PR changes files outside therecipes/directory.').

cisaacstern commented 2 years ago

As it turns out, this is our first experience trying to create recipe runs from a PR on a feedstock, which is what caused the error reported above. I'll fix this now.

cisaacstern commented 2 years ago

I believe the structure error issue was resolved in https://github.com/pangeo-forge/registrar/pull/27, so I'll now just make an arbitrary commit of some sort, to re-trigger recipe run creation on the PR. manually re-trigger the recipe run creation.

pangeo-forge-bot commented 2 years ago

I'm having trouble finding your recipe module (i.e. Python file) in this PR.

Your meta.yaml recipes section currently includes a recipe declared as:

- id: noaa-coastwatch-geopolar-sst
    object: recipe:recipe

The object here should conform to the format {recipe-module-name}:{recipe-object-name}.

In your PR I only see the following files:

['feedstock/meta.yaml']

...none of which end with recipe.py, which is unexpected given the object shown above.

Please help me find your recipe module by either:

cisaacstern commented 2 years ago

Hmm, because this PR only changes the meta.yaml, maybe we don't really need to bother creating recipe runs. This is sort of an edge case where changing something in meta.yaml could affect the runtime behavior (because we're changing the pangeo_forge_version). Figuring out to do about this seems beyond the scope of investigating #2, so I'm just going to leave this like this for now, and merge.