search

pangeo-forge / pangeo-forge-cloud-federation

Infrastructure for running pangeo-forge across multiple bakeries
Apache License 2.0
3 stars 6 forks source link

Add validate action #12

Closed thodson-usgs closed 5 months ago

thodson-usgs commented 8 months ago

Adds an action to validate terraform on pushes and pull requests.

thodson-usgs commented 7 months ago

@yuvipanda, I don't think -bankend-config will work for this case. Please advise.

thodson-usgs commented 5 months ago

@ranchodeluxe, would you mind picking up this review?

This PR would add an action to run terraform validate. Best practice might be to run the full apply & destroy, but there are several reasons to avoid that in this case.

As far as I'm aware, this is good to go and tested on my fork.

ranchodeluxe commented 5 months ago

@ranchodeluxe, would you mind picking up this review?

This PR would add an action to run terraform validate. Best practice might be to run the full apply & destroy, but there are several reasons to avoid that in this case.

As far as I'm aware, this is good to go and tested on my fork.

Yeah, unless a repo is private I tend to not use plan || apply in GH actions and if then in separate steps to avoid bad juju.